Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigational note from ref-safe-context to safe-context #903

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Aug 17, 2023

(And fix a bit of formatting.)

Fixes #901.

cc @KalleOlaviNiemitalo

@KalleOlaviNiemitalo
Copy link
Contributor

I think I'd prefer having the note higher up, visually separating it from the examples.

@jskeet
Copy link
Contributor Author

jskeet commented Aug 17, 2023

I think I'd prefer having the note higher up, visually separating it from the examples.

I've added a second commit which puts it pretty much at the start of the section. I'm not convinced there's a good place for it other than at the start or the end... we'll see what others think.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this @jskeet

I like the note at the beginning. It is useful for readers to have the relationship in mind before reading the section.

Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit d4fa579 into dotnet:draft-v7 Aug 17, 2023
7 checks passed
@jskeet jskeet deleted the ref-struct-note branch August 17, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

§9.7.2.1: Reference §16.4.12 for clarity
4 participants