Adjust compatibility rules for Apple TFMs. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: xamarin/xamarin-macios#13087 We've decided to ship breaking changes with .NET 6 for iOS, macOS and tvOS, and as such we won't be compatible with existing TFMs. All binaries will have be recompiled for .NET 6. I've modified compatibility scenarios that involve iOS or Mac Catalyst to use Android instead (because the compatibility rules for Android won't change).
|
This will need to happen in net6 servicing not in net6 GA so wondering if we should mention that in the design. |
|
CC @JonDouglas |
|
@mhutch & @terrajobst Can we get a quick review? |
nkolev92
reviewed
Oct 22, 2021
| * Generate NuGet warning [NU1701] when a `xamarin.ios` asset is being used | ||
| - Package 'packageId' was restored using 'xamarin.ios' instead the project | ||
| target framework 'net6.0-maccatalyst'. This package may not be fully | ||
| * Generate NuGet warning [NU1701] when a `monoandroid` asset is being used |
There was a problem hiding this comment.
Is the proposal effectively making monoandroid AssetTargetFallback for net6.0-android?
Would monoandroid appear before or after netframework?
There was a problem hiding this comment.
nothing changes for android, this just updates the examples since the xamarin.ios examples no longer apply.
There was a problem hiding this comment.
Should have read the new version, the diffs threw me for a loop :D
Thanks.
terrajobst
approved these changes
Oct 27, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/xamarin-macios#13087
We've decided to ship breaking changes with .NET 6 for iOS, macOS and tvOS,
and as such we won't be compatible with existing TFMs. All binaries will have
be recompiled for .NET 6.
I've modified compatibility scenarios that involve iOS or Mac Catalyst to use
Android instead (because the compatibility rules for Android won't change).