-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --cpus context #267
Merged
Merged
Add --cpus context #267
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bc4a845
Add --cpus context
richlander 172b30d
Add comment about .NET Framework
richlander 1558f19
Clarify CPU affinity
richlander e7527c9
Update accepted/2019/support-for-memory-limits.md
richlander 8aced4a
Update accepted/2019/support-for-memory-limits.md
richlander d6b79ac
Add more context
richlander 593dfa6
Add GCHeapCount
richlander 99192e0
Update accepted/2019/support-for-memory-limits.md
richlander 9f0970c
MiB -> MB
richlander 50cd55b
Update per feedback
richlander edd1bb9
Update index.md
richlander 92c93b1
Add runtime config doc link
richlander e900593
Update per feedbac
richlander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add an example of what a
GCHeapHardLimit
hex value looks like? Does it have a prefix like0xf00d
orf00d
?For
GCHeapHardLimitPercent
, does it range from 0 to 100 (or hex0x0
to0x64
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the full documentation with examples and other details at https://docs.microsoft.com/en-us/dotnet/core/runtime-config/garbage-collector
Should we move some of these edits to the official docs instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think just having links to the full docs will be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the link to the doc.