Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-binding-basics.md #1610

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

thimanshu1993
Copy link
Contributor

@thimanshu1993 thimanshu1993 commented Jul 26, 2023

Added reference link so that user can check ObservableCollection class in detail from link : "https://learn.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1?view=net-7.0"


Internal previews

📄 File 🔗 Preview link
docs/xaml/fundamentals/data-binding-basics.md Data binding basics

Added reference link so that user can check ObservableCollection class in detail from link :
"https://learn.microsoft.com/en-us/dotnet/api/system.collections.objectmodel.observablecollection-1?view=net-7.0"
Removed language specifics from URL
@davidbritch
Copy link
Contributor

@thimanshu1993 The correct way to do this is with an xref. See the change I'm about to make.

Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbritch davidbritch merged commit 5e8b105 into dotnet:main Jul 26, 2023
4 checks passed
@thimanshu1993
Copy link
Contributor Author

@thimanshu1993 The correct way to do this is with an xref. See the change I'm about to make.

Thanks @davidbritch for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants