Update theming.md #2515
Merged
Update theming.md #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved notes for better understanding and fixed an open issue.
davidbritch
approved these changes
Oct 1, 2024
MartyIX
reviewed
Oct 1, 2024
| @@ -18,14 +18,14 @@ The process for implementing runtime theming in a .NET MAUI app is as follows: | |||
| 1. Add code to load a theme at runtime. For more information, see [Load a theme at runtime](#load-a-theme-at-runtime). | |||
|
|
|||
| > [!IMPORTANT] | |||
| > Use the [`StaticResource`](xref:Microsoft.Maui.Controls.Xaml.StaticResourceExtension) markup extension if your app doesn’t need to change themes dynamically at runtime. This approach resolves resources at load time, making it more efficient for static themes. However, if you anticipate switching themes (e.g., between light and dark modes) while the app is running, use [`DynamicResource`](xref:Microsoft.Maui.Controls.Xaml.DynamicResourceExtension), which allows resources to update during runtime. | |||
| > Use the [`StaticResource`](xref:Microsoft.Maui.Controls.Xaml.StaticResourceExtension) markup extension if your app doesn’t need to change themes dynamically at runtime. If you anticipate switching themes while the app is running, use the [`DynamicResource`](xref:Microsoft.Maui.Controls.Xaml.DynamicResourceExtension) markup extension, which enables resources to be updated at runtime. | |||
There was a problem hiding this comment.
Suggested change
| > Use the [`StaticResource`](xref:Microsoft.Maui.Controls.Xaml.StaticResourceExtension) markup extension if your app doesn’t need to change themes dynamically at runtime. If you anticipate switching themes while the app is running, use the [`DynamicResource`](xref:Microsoft.Maui.Controls.Xaml.DynamicResourceExtension) markup extension, which enables resources to be updated at runtime. | |
| > Use the [`StaticResource`](xref:Microsoft.Maui.Controls.Xaml.StaticResourceExtension) markup extension if your app doesn't need to change themes dynamically at runtime. If you anticipate switching themes while the app is running, use the [`DynamicResource`](xref:Microsoft.Maui.Controls.Xaml.DynamicResourceExtension) markup extension, which enables resources to be updated at runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved notes for better understanding and fixed an open issue.
See issue: #2348