Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new SYSLIB warnings #23856

Closed
24 tasks done
gewarren opened this issue Apr 20, 2021 · 3 comments · Fixed by #25988
Closed
24 tasks done

Add new SYSLIB warnings #23856

gewarren opened this issue Apr 20, 2021 · 3 comments · Fixed by #25988
Assignees
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 6 Issues and PRs for the .NET 6 release doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3

Comments

@gewarren
Copy link
Contributor

gewarren commented Apr 20, 2021

Update this page based on https://github.com/dotnet/runtime/blob/main/docs/project/list-of-diagnostics.md.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@gewarren gewarren added the doc-enhancement Improve the current content [org][type][category] label Apr 20, 2021
@gewarren gewarren self-assigned this Apr 20, 2021
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Apr 20, 2021
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Apr 20, 2021
@jeffhandley
Copy link
Member

@gewarren I want to confirm that you plan to review the list-of-diagnostics.md file and gather all of the new diagnostics from there to produce the breaking change document, and that (so long as we accumulate the diagnostics there) we do not need to submit separate issues for each new obsoletion. Is that correct?

If that's the case, would it still be helpful for us to link to this issue from each PR that introduces a diagnostic?

@gewarren
Copy link
Contributor Author

@jeffhandley Yes, that's correct, and you don't need to submit separate issues. But I think it would be helpful to link to this issue from the PRs, as a sign that there's a new one to add to the breaking changes doc. Thanks!

@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Aug 5, 2021

The SYSLIB0027-SYSLIB0031 links aren't rendering correctly at https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/obsolete-apis-with-custom-diagnostics. Please use parentheses around the URI-references: for example, [SYSLIB0027](../../../../fundamentals/syslib-diagnostics/syslib0027.md) rather than [SYSLIB0027][../../../../fundamentals/syslib-diagnostics/syslib0027.md].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 6 Issues and PRs for the .NET 6 release doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants