-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new syslib warnings #23915
Add new syslib warnings #23915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks! If you want to add SYSLIB0017
and SYSLIB0018
in while you're at it, those are included in dotnet/runtime#50941.
@@ -0,0 +1,17 @@ | |||
--- | |||
title: SYSLIB0013 warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://aka.ms/dotnet-warnings/SYSLIB0013
may need to get updated to this article after it's published. (Same applies to other obsoletion warnings.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffhandley I don't seem to have access to these aka.ms links. Can you update for 13-16, 19-20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will publish these live now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and created the aka.ms links for SYSLIB0017 through SYSLIB0025. I don't (yet) have access to edit the existing ones, but I submitted a request to gain access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, when you're ready.
Contributes to #23856
Internal preview.