Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new syslib warnings #23915

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Add new syslib warnings #23915

merged 8 commits into from
Apr 26, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 23, 2021

Contributes to #23856

Internal preview.

@gewarren gewarren requested review from jeffhandley and a team April 23, 2021 23:49
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks! If you want to add SYSLIB0017 and SYSLIB0018 in while you're at it, those are included in dotnet/runtime#50941.

@@ -0,0 +1,17 @@
---
title: SYSLIB0013 warning
Copy link
Member

@Youssef1313 Youssef1313 Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://aka.ms/dotnet-warnings/SYSLIB0013 may need to get updated to this article after it's published. (Same applies to other obsoletion warnings.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffhandley I don't seem to have access to these aka.ms links. Can you update for 13-16, 19-20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will publish these live now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and created the aka.ms links for SYSLIB0017 through SYSLIB0025. I don't (yet) have access to edit the existing ones, but I submitted a request to gain access.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@gewarren gewarren merged commit f18277a into dotnet:main Apr 26, 2021
@gewarren gewarren deleted the syslib branch April 26, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants