Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document OptimizeImplicitlyTriggeredBuild property #25214

Closed
Youssef1313 opened this issue Jul 19, 2021 · 1 comment · Fixed by #26245
Closed

Document OptimizeImplicitlyTriggeredBuild property #25214

Youssef1313 opened this issue Jul 19, 2021 · 1 comment · Fixed by #26245
Assignees
@gewarren
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc help wanted Good for community contributors to help [up-for-grabs] Pri1 High priority, do before Pri2 and Pri3

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 19, 2021 •
edited by gewarren
Loading

This was added in dotnet/roslyn#54143 for dev17 and enhanced in dotnet/roslyn#54913.

For builds which are indirectly triggered inside Visual Studio from commands such as from 'Run Tests' or 'Start Debugging', we implicitly skip analyzers and nullable analysis to speed up the build.
We only do so by default when 'TreatWarningsAsErrors' is not 'true'. For the scenario where 'TreatWarningsAsErrors' is 'true', users can explicitly enable this functionality by setting 'OptimizeImplicitlyTriggeredBuild' to 'true'.

cc @mavasani @gewarren

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jul 19, 2021
@gewarren gewarren added doc-enhancement Improve the current content [org][type][category] help wanted Good for community contributors to help [up-for-grabs] Pri1 High priority, do before Pri2 and Pri3 and removed ⌚ Not Triaged Not triaged Pri3 labels Jul 19, 2021
@mavasani mavasani mentioned this issue Jul 20, 2021
Merged
@mavasani
Copy link
Contributor

We should also document compiler's nullable analysis being implicitly skipped for implicitly triggered builds: dotnet/roslyn#54913

@gewarren gewarren self-assigned this Sep 23, 2021
@gewarren gewarren mentioned this issue Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc help wanted Good for community contributors to help [up-for-grabs] Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add OptimizeImplicitlyTriggeredBuild property gewarren/docs
6 participants
@dotnet-bot @mavasani @gewarren @PRMerger20 @PRMerger18 @Youssef1313