Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicitly skip compiler's nullable analysis when implicitly skipping… #54913

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Jul 19, 2021

… analyzers

Follow-up to #54143
Work towards AB#1337109

This improves the build time for implicitly triggered builds by approximately 7-8% when nullable has been enabled for the project.

@mavasani
Copy link
Contributor Author

@jaredpar Any further feedback?

@jcouv jcouv self-assigned this Jul 29, 2021
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@mavasani mavasani merged commit 86ff365 into dotnet:main Jul 30, 2021
@ghost ghost modified the milestones: 17.0.P3, Next Jul 30, 2021
@mavasani mavasani deleted the ImplicitlySkipNullable branch July 30, 2021 01:43
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants