-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run Markdownlint with GitHub Actions #15184
Conversation
Here is the demo of it working on my fork (although currently failing from a few Markdownlint issues) https://github.com/nschonni/dotnet-docs/commit/12a44f9c3c47d174e818d5ddfba6db71ffc81417/checks?check_suite_id=264969966 |
That's an interesting idea @nschonni. Let me discuss that with the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mairaw curious to hear how the trial has gone |
Hey @nschonni, I think it's working well with a couple of false positives and some interesting side effects if you close and reopen a PR. Some folks don't like the automated runs but I think most of our team would like to continue with this. |
Thanks! Do you think that pinning to a specific version would help. EX: create a specific Action for MSDocs that wraps this and keeps a particular version of Markdownlint(-cli) in use till all projects are ready for new rules? I know I've gotten bitten/annoyed when new rules get added and previously passing things now fail, and you have to update your config just till you can look at them |
Summary
More as a discussion point, since this is something i'm sure there is a policy on using/not using GitHub Actions. General idea was that you could ignore these failures if you don't care about them, but can help outside of the OpenPublishing builds.