Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet publish CLI ref updates #17787

Merged
merged 5 commits into from
Apr 10, 2020
Merged

dotnet publish CLI ref updates #17787

merged 5 commits into from
Apr 10, 2020

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Apr 10, 2020 •
edited
Loading

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 10, 2020
@tdykstra tdykstra requested review from gewarren and removed request for gewarren April 10, 2020 16:08
@tdykstra tdykstra changed the title dotnet publish CLI ref updates WIP: dotnet publish CLI ref updates Apr 10, 2020
gewarren
gewarren approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, otherwise looks great!

docs/core/tools/dotnet-publish.md Outdated
@@ -17,7 +17,8 @@ ms.date: 02/24/2020
dotnet publish [<PROJECT>|<SOLUTION>] [-c|--configuration]
[-f|--framework] [--force] [--interactive] [--manifest]
[--no-build] [--no-dependencies] [--no-restore] [--nologo]
[-o|--output] [-r|--runtime] [--self-contained]
[-o|--output] [-p:PublishSingleFile] [-p:PublishTrimmed]
[-p:PublishReadyToRun] [-r|--runtime] [--self-contained]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't quite alphabetic.

@tdykstra tdykstra changed the title WIP: dotnet publish CLI ref updates dotnet publish CLI ref updates Apr 10, 2020
@tdykstra
Copy link
Contributor Author

Thanks, @gewarren

@tdykstra tdykstra merged commit 393138b into dotnet:master Apr 10, 2020
@tdykstra tdykstra deleted the publishsinglefile branch April 10, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
cli/subsvc
Projects
None yet
Milestone
April 2020
4 participants
@tdykstra @gewarren @BillWagner @dotnet-bot