Added missing metrics for .NET extensions. #37875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tdykstra
approved these changes
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
Co-authored-by: Tom Dykstra <[email protected]>
gewarren
reviewed
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
IEvangelist
commented
Nov 2, 2023
Co-authored-by: Genevieve Warren <[email protected]>
|
|
||
| This article describes the metrics built-in for ASP.NET Core produced using the | ||
| <xref:System.Diagnostics.Metrics?displayProperty=nameWithType> API. For a listing of metrics based on the older [EventCounters](event-counters.md) API, | ||
| see [here](available-counters.md). | ||
|
|
||
| - [Meter: `Microsoft.AspNetCore.HeaderParsing`](#meter-microsoftaspnetcoreheaderparsing) |
There was a problem hiding this comment.
Since Microsoft.AspNetCore.HeaderParsing is a part of dotnet/extensions, shouldn't we move description of this meter and its metrics to ".NET extensions metrics" article? @IEvangelist
There was a problem hiding this comment.
That's a fair question, but I'd argue "no". This package, while it ships out of dotnet/extensions is specific to ASP.NET Core and isn't workload agnostic, therefore it belongs with the other ASP.NET Core specific metrics (otherwise we're shipping our org chart so to speak). I suppose we should defer to @davidfowl and @joperezr, but I feel very strongly about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added missing metrics for .NET extensions.
Contributes to #37411 and #37835
Tagging @iliar-turdushev and @davidfowl
Internal previews