Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component-design-guidelines.md #38349

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update component-design-guidelines.md #38349

merged 2 commits into from
Dec 4, 2023

Conversation

smoothdeveloper
Copy link
Contributor

@smoothdeveloper smoothdeveloper commented Nov 21, 2023 •
edited by github-actions bot
Loading

being very explicit about good practices related to [<RequireQualifiedAccess>] when defining modules that shadow or extend others that have the attribute.

Language design notes:

  • we should consider a soft RequireQualifiedAccess mode, which gives a warning, allows API authors to do a warning wave on future change
  • we should consider warnings / analyzer to implement the rules that are suggested in this edit

related:

Internal previews

📄 File 🔗 Preview link
docs/fsharp/style-guide/component-design-guidelines.md F# component design guidelines

@smoothdeveloper
Update component-design-guidelines.md
73da7f1 
being very explicit about good practices related to `[<RequireQualifiedAccess>]` when defining modules that shadow or extend others that have the attribute.

Language design notes:
* we should consider a soft RequireQualifiedAccess mode, which gives a warning, allows API authors to do a warning wave on future change
* we should consider warnings / analyzer to implement the rules that are suggested in this edit
@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 21, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 21, 2023
@smoothdeveloper
Update component-design-guidelines.md
fb8928f 
lint over trailingspace
BillWagner
BillWagner approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit:

@BillWagner BillWagner merged commit 5b2d3b4 into dotnet:main Dec 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard KathleenDollard is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@smoothdeveloper @BillWagner @dotnet-bot