Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the section on resilience and static clients #39010

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jan 9, 2024

Summary

This section should use the latest Polly v8 and Microsoft.Extensions.Http.Resilience package as Polly v7 is not developed anymore.

We should wait a while before merging this, after new version of Microsoft.Extensions.Http.Resilience is available that contains the ResilienceHandler type. (dotnet/extensions#4858)


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/networking/http/httpclient-guidelines.md Guidelines for using HttpClient

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CarnaViire CarnaViire added blocked Blocked for some reason DO NOT MERGE labels Jan 9, 2024
@CarnaViire
Copy link
Member

@martintmk is there any ETA on when the new version of the package will be published?

@martintmk
Copy link
Contributor Author

@martintmk is there any ETA on when the new version of the package will be published?

It should have monthly cadence. I'll keep an eye on this and merge once the new version is available.

@IEvangelist IEvangelist merged commit d3a0d50 into main Jan 10, 2024
8 checks passed
@IEvangelist IEvangelist deleted the mtomka/update-http-resilience-section branch January 10, 2024 14:04
@CarnaViire
Copy link
Member

oops @IEvangelist I think it was too early to merge, the package is not available yet...

@IEvangelist
Copy link
Member

IEvangelist commented Jan 10, 2024

oops @IEvangelist I think it was too early to merge, the package is not available yet...

Hi @CarnaViire - This package has been available since .NET 8 and I wrote about it here: https://learn.microsoft.com/dotnet/core/resilience/http-resilience?tabs=dotnet-cli

@CarnaViire
Copy link
Member

As discussed offline, we need a new version of the package that is not out yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants