Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: document waithandle keyword #40852

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

This keyword was added for .NET 9+
@verdie-g verdie-g requested review from tommcdon and a team as code owners May 11, 2024 03:06
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label May 11, 2024
@tommcdon
Copy link
Member

This was added on dotnet/diagnostics#4624 however we haven't shipped the updated version of dotnet-trace containing this change. @mikem8361 @hoyosjs - we should merge this doc PR after we ship an updated version of the diagnostic tools.

Copy link
Member

@tommcdon tommcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hold on merging this PR until we have shipped an updated version of dotnet-trace

@verdie-g verdie-g changed the title dotnet-trace: document waithandle keyword diagnostic: document waithandle keyword May 28, 2024
@verdie-g
Copy link
Author

@tommcdon I added some documentation for the event so it would appear in https://learn.microsoft.com/en-us/dotnet/fundamentals/diagnostics/runtime-events.

@BillWagner BillWagner modified the milestones: May 2024, June 2024 Jun 3, 2024
@BillWagner BillWagner modified the milestones: June 2024, July 2024 Jul 1, 2024
@BillWagner
Copy link
Member

ping @tommcdon Is this still waiting, or is it ready?

@BillWagner BillWagner modified the milestones: July 2024, August 2024 Aug 13, 2024
@verdie-g
Copy link
Author

The change was released in https://github.com/dotnet/diagnostics/releases/tag/v8.0.532401

Add waithandle to clrevents option.

@BillWagner
Copy link
Member

@tommcdon

I looks like this feel through the cracks for final review. You'd marked it as "changes requested". Can you take a look?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added markdown lint fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants