-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diagnostic: document waithandle keyword #40852
base: main
Are you sure you want to change the base?
Conversation
This keyword was added for .NET 9+
This was added on dotnet/diagnostics#4624 however we haven't shipped the updated version of dotnet-trace containing this change. @mikem8361 @hoyosjs - we should merge this doc PR after we ship an updated version of the diagnostic tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should hold on merging this PR until we have shipped an updated version of dotnet-trace
@tommcdon I added some documentation for the event so it would appear in https://learn.microsoft.com/en-us/dotnet/fundamentals/diagnostics/runtime-events. |
ping @tommcdon Is this still waiting, or is it ready? |
The change was released in https://github.com/dotnet/diagnostics/releases/tag/v8.0.532401
|
I looks like this feel through the cracks for final review. You'd marked it as "changes requested". Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added markdown lint fixes
This keyword was added for .NET 9+
Internal previews