Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license properties to csproj documentation #9390

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Dec 4, 2018

Part of the text is from the equivalent tag in nuspec documentation

NuGet change is NuGet/Home#4628 released in SDK 2.1.500

Part of the text is from the equivalent tag in [nuspec documentation](https://docs.microsoft.com/en-us/nuget/reference/nuspec#license)

NuGet change is NuGet/Home#4628 released in SDK 2.1.500
@vbfox vbfox requested a review from mairaw as a code owner December 4, 2018 22:34
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @vbfox

I'll :shipit: now.

@BillWagner BillWagner merged commit f1cd0ce into dotnet:master Feb 22, 2019
@vbfox
Copy link
Contributor Author

vbfox commented Feb 25, 2019

@BillWagner The properties now appear in double, It seem that they were added in 19dc1ea#diff-726f4691cd84b42735985bae55acd85d

@BillWagner
Copy link
Member

Thanks for noticing that @vbfox

I thought I had merged the separate PRs correctly. Fixing now...

BillWagner added a commit to BillWagner/docs that referenced this pull request Feb 25, 2019
BillWagner added a commit that referenced this pull request Feb 25, 2019
* fix a merge the created duplicated content.

See #9390 (comment)

* Update docs/core/tools/csproj.md

Co-Authored-By: BillWagner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants