Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark discouraging HttpRequestMessage reuse #8224

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

MihaZupan
Copy link
Member

Summary

Document that modifying and/or reusing an HttpRequestMesssage instance after it has been sent is discouraged (things may blow up in interesting ways at runtime).

Contributes to dotnet/runtime#66989

@MihaZupan MihaZupan requested a review from a team as a code owner July 15, 2022 18:40
@ghost ghost assigned MihaZupan Jul 15, 2022
@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Document that modifying and/or reusing an HttpRequestMesssage instance after it has been sent is discouraged (things may blow up in interesting ways at runtime).

Contributes to dotnet/runtime#66989

Author: MihaZupan
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@opbld30
Copy link

opbld30 commented Jul 15, 2022

Docs Build status updates of commit 0bda0c1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants