Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Ubuntu 16.04 and move images to 22.04 #678

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Delete Ubuntu 16.04 and move images to 22.04 #678

merged 1 commit into from
Aug 30, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 26, 2022

No description provided.

@am11 am11 force-pushed the feature/cross-build/move-platforms-16.04 branch from d9d4fe3 to a159147 Compare August 26, 2022 15:51
@am11 am11 marked this pull request as ready for review August 26, 2022 16:12
@am11 am11 force-pushed the feature/cross-build/move-platforms-16.04 branch 3 times, most recently from 5b92b22 to 4751e79 Compare August 26, 2022 18:19
@am11 am11 force-pushed the feature/cross-build/move-platforms-16.04 branch from 4751e79 to 0dd726c Compare August 26, 2022 19:03
@mthalman mthalman requested a review from MattGal August 29, 2022 15:21
mthalman
mthalman reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not an equal number of file adds compared to deletions. Why are some of the Dockerfiles not being moved over?

@am11
Copy link
Member Author

am11 commented Aug 29, 2022

Why are some of the Dockerfiles not being moved over?

They are not used anymore:

  • we previously moved dpkg to Ubuntu 18 and 22 (and used 18 one in runtime)
  • 16-cross-arm (32) is not used anywhere in github.com/dotnet org (those legs are moved to newer image).

Moreover, existing tags will continue to work, there are no changes coming to 16.04 anymore from Debian's side, so we won't miss anything. We can gradually move the CI legs to newer LTS images.

mthalman
mthalman approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just want to get confirmation from @MattGal too that this will be ok.

@MattGal
Copy link
Member

MattGal commented Aug 29, 2022

LGTM. Just want to get confirmation from @MattGal too that this will be ok.

No objections here; we maintain "real" ubuntu 16.04 agents anyways for Helix test purposes, so long term .NET Core support for 16.04 shouldn't be affected. Tagging @rbhanda as an FYI just in case he has concerns too.

@mthalman mthalman merged commit b016fdd into dotnet:main Aug 30, 2022
@am11 am11 mentioned this pull request Sep 2, 2022
Merged
rzikm pushed a commit to rzikm/dotnet-buildtools-prereqs-docker that referenced this pull request Sep 27, 2022
@am11 @rzikm
Delete Ubuntu 16.04 and move images to 22.04 (dotnet#678)
6d2fa59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattGal MattGal MattGal approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
area-dockerfiles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @MattGal @mthalman