Bundles: Allow argument separator (--)

Fixes #26945
dotnet · Jan 7, 2022 · 5f90495 · 5f90495
1 parent bbbd2c8
commit 5f90495
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs b/src/EFCore.Design/Migrations/Design/MigrationsBundle.cs
@@ -40,11 +40,8 @@ public static int Execute(string? context, Assembly assembly, Assembly startupAs
             _assembly = assembly;
             _startupAssembly = startupAssembly;
 
-            var app = new CommandLineApplication
-            {
-                Name = "bundle",
-                HandleResponseFiles = true
-            };
+            var app = new CommandLineApplication { Name = "efbundle" };
+
             Configure(app);
 
             try
@@ -73,6 +70,7 @@ public static int Execute(string? context, Assembly assembly, Assembly startupAs
         internal static void Configure(CommandLineApplication app)
         {
             app.FullName = DesignStrings.BundleFullName;
+            app.AllowArgumentSeparator = true;
 
             _migration = app.Argument("<MIGRATION>", DesignStrings.MigrationDescription);
             _connection = app.Option("--connection <CONNECTION>", DesignStrings.ConnectionDescription);
@@ -83,6 +81,8 @@ internal static void Configure(CommandLineApplication app)
             var noColor = app.Option("--no-color", DesignStrings.NoColorDescription);
             var prefixOutput = app.Option("--prefix-output", DesignStrings.PrefixDescription);
 
+            app.HandleResponseFiles = true;
+
             app.OnExecute(
                 args =>
                     {

diff --git a/test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs b/test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs
@@ -44,9 +44,27 @@ public void Long_names_are_unique()
             }
         }
 
+        [Fact]
+        public void HandleResponseFiles_is_true()
+        {
+            var app = new CommandLineApplication { Name = "efbundle" };
+            MigrationsBundle.Configure(app);
+
+            Assert.True(app.HandleResponseFiles);
+        }
+
+        [Fact]
+        public void AllowArgumentSeparator_is_true()
+        {
+            var app = new CommandLineApplication { Name = "efbundle" };
+            MigrationsBundle.Configure(app);
+
+            Assert.True(app.AllowArgumentSeparator);
+        }
+
         private static IEnumerable<CommandLineApplication> GetCommands()
         {
-            var app = new CommandLineApplication { Name = "bundle" };
+            var app = new CommandLineApplication { Name = "efbundle" };
 
             MigrationsBundle.Configure(app);