Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosDb: Investigate why pooling does not work in Northwind tests #12878

Open
smitpatel opened this issue Aug 2, 2018 · 2 comments
Open

CosmosDb: Investigate why pooling does not work in Northwind tests #12878

smitpatel opened this issue Aug 2, 2018 · 2 comments
Labels
area-cosmos area-test punted-for-3.0 type-bug
Milestone
MQ

Comments

@smitpatel
Copy link
Contributor

No description provided.

@smitpatel smitpatel mentioned this issue Aug 2, 2018
Merged
@ajcvickers ajcvickers added this to the 2.2.0 milestone Aug 3, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Sep 11, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview3, 2.2.0, 3.0.0 Oct 15, 2018
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel assigned smitpatel and unassigned AndriySvyryd Nov 5, 2020
smitpatel added a commit that referenced this issue Nov 5, 2020
@smitpatel
Cosmos: Enable DbContext pooling
e466eee 
Resolves #12878
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 5, 2020
@smitpatel smitpatel mentioned this issue Nov 5, 2020
Closed
@smitpatel smitpatel removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 6, 2020
@smitpatel
Copy link
Contributor Author

Current error seems to be coming from 2 things

  • With pooling on, our cosmos test throughput increases even further which emulator in PR failed to serve. (Local works fine). There are request failures in some tests.
  • There may be some concurrency issue in creating database too. Local run with database already created works fine. For PR run, most failed tests did not have any results indicating no data in tables or partial data.

@smitpatel smitpatel removed their assignment Nov 6, 2020
@smitpatel smitpatel removed this from the 6.0.0 milestone Nov 6, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Nov 6, 2020
@ajcvickers
Copy link
Member

Note from triage: low-pri test bug; consider for next MQ.

@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Nov 4, 2021
@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
@ajcvickers ajcvickers modified the milestones: MQ, 9.0.0 May 8, 2024
@ajcvickers ajcvickers assigned ajcvickers and unassigned AndriySvyryd May 8, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, MQ Jul 1, 2024
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos area-test punted-for-3.0 type-bug
Projects
None yet
Milestone
MQ
Development

Successfully merging a pull request may close this issue.

Cosmos: Enable DbContext pooling dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd