Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query with null-coalesced entity gets client-evaluated #13568

Closed
Wain123 opened this issue Oct 10, 2018 · 1 comment · Fixed by #20447
Closed

Query with null-coalesced entity gets client-evaluated #13568

Wain123 opened this issue Oct 10, 2018 · 1 comment · Fixed by #20447
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
5.0.0

Comments

@Wain123
Copy link

Wain123 commented Oct 10, 2018

This query throws a QueryClientEvaluationWarning:

Blog a = ctx.Blogs.First();
Blog b = a;
ctx.Posts.Where(p => p.Blog == (a ?? b)).Count();

As a workaround, I can compare the PK instead of the navigation:

decimal? a = ctx.Blogs.First().Seqnr;
decimal? b = a;
ctx.Posts.Where(p => p.Blog.Seqnr == (a ?? b)).Count();

EF Core version: 2.1.1
Database Provider: Microsoft.EntityFrameworkCore.Oracle
Operating system: Windows 10
IDE: Visual Studio Professional 2017 15.8.6
@Wain123 Wain123 mentioned this issue Oct 10, 2018
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone Oct 12, 2018
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jan 24, 2019
@smitpatel smitpatel removed their assignment Jan 29, 2019
@smitpatel smitpatel self-assigned this Mar 16, 2020
@smitpatel
Copy link
Contributor

Related #20164

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 28, 2020
@smitpatel smitpatel modified the milestones: Backlog, 5.0.0 Mar 28, 2020
smitpatel added a commit that referenced this issue Mar 28, 2020
@smitpatel
Query: Rewrite Entity Equality during translation phase
24718b0 
Resolves #15080
Implemented behavior:
- If any part of composite key is null then key is null.
- If comparing entity with null then check if "any" key value is null.
- If comparing entity with non-null then check if "all" key values are non null.

Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.

Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.

Resolves #20164
Rewrites entity equality during translation

Part of #18923
smitpatel added a commit that referenced this issue Mar 28, 2020
@smitpatel
Query: Rewrite Entity Equality during translation phase
ba04dd0 
Resolves #15080
Implemented behavior:
- If any part of composite key is null then key is null.
- If comparing entity with null then check if "any" key value is null.
- If comparing entity with non-null then check if "all" key values are non null.

Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.

Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.

Resolves #20164
Rewrites entity equality during translation

Part of #18923
@smitpatel smitpatel mentioned this issue Mar 28, 2020
Merged
smitpatel added a commit that referenced this issue Mar 28, 2020
@smitpatel
Query: Rewrite Entity Equality during translation phase
904a105 
Resolves #15080
Implemented behavior:
- If any part of composite key is null then key is null.
- If comparing entity with null then check if "any" key value is null.
- If comparing entity with non-null then check if "all" key values are non null.

Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.

Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.

Resolves #20164
Rewrites entity equality during translation

Part of #18923
smitpatel added a commit that referenced this issue Mar 31, 2020
@smitpatel
Query: Rewrite Entity Equality during translation phase
b7360ca 
Resolves #15080
Implemented behavior:
- If any part of composite key is null then key is null.
- If comparing entity with null then check if "any" key value is null.
- If comparing entity with non-null then check if "all" key values are non null.

Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.

Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.

Resolves #20164
Rewrites entity equality during translation

Part of #18923
smitpatel added a commit that referenced this issue Mar 31, 2020
@smitpatel
Query: Rewrite Entity Equality during translation phase
bb88898 
Resolves #15080
Implemented behavior:
- If any part of composite key is null then key is null.
- If comparing entity with null then check if "any" key value is null.
- If comparing entity with non-null then check if "all" key values are non null.

Resolves #20344
Resolves #19431
Resolves #13568
Resolves #13655
Since we already convert property access to nullable, if entity from client is null, make key value as null.

Resolves #19676
Clr type mismatch between proxy type and entity type is ignored.

Resolves #20164
Rewrites entity equality during translation

Part of #18923
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview3 Mar 31, 2020
@smitpatel smitpatel modified the milestones: 5.0.0-preview3, 5.0.0 Apr 1, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Rewrite Entity Equality during translation phase dotnet/efcore
3 participants
@ajcvickers @smitpatel @Wain123