Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: SqlServer LongCount #15718

Closed
smitpatel opened this issue May 14, 2019 · 1 comment
Closed

Query: SqlServer LongCount #15718

smitpatel opened this issue May 14, 2019 · 1 comment
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

Because it uses a different SqlFunction
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 17, 2019
roji added a commit to roji/efcore that referenced this issue May 22, 2019
@roji
Translate LongCount() on SqlServer
f12c064 
Includes refactoring that makes it easier for providers to override
behavior.

Fixes dotnet#15718
@roji roji mentioned this issue May 22, 2019
Closed
@roji
Copy link
Member

roji commented May 22, 2019

Abortive attempt in #15774, defer this until GroupBy is fully fleshed out.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
smitpatel added a commit that referenced this issue Jul 1, 2019
@smitpatel
Query: Move processing of aggregate functions inside SqlTranslator
1ec33ad 
This allows us to use those methods to translate aggregates after GroupBy

Resolves #15718
@smitpatel smitpatel mentioned this issue Jul 1, 2019
Merged
smitpatel added a commit that referenced this issue Jul 2, 2019
@smitpatel
Query: Move processing of aggregate functions inside SqlTranslator
9ac81cf 
This allows us to use those methods to translate aggregates after GroupBy

Resolves #15718
smitpatel added a commit that referenced this issue Jul 2, 2019
@smitpatel
Query: Move processing of aggregate functions inside SqlTranslator
fd9ac43 
This allows us to use those methods to translate aggregates after GroupBy

Resolves #15718
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 2, 2019
@smitpatel smitpatel assigned smitpatel and unassigned roji Jul 2, 2019
@smitpatel smitpatel modified the milestones: Backlog, 3.0.0 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@smitpatel smitpatel modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers removed this from the 3.0.0-preview7 milestone Nov 11, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Translate LongCount() on SqlServer roji/efcore
3 participants
@ajcvickers @smitpatel @roji