Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Improve exception message when subquery pushdown is needed #16156

Closed
smitpatel opened this issue Jun 19, 2019 · 1 comment · Fixed by #30849
Closed

Cosmos: Improve exception message when subquery pushdown is needed #16156

smitpatel opened this issue Jun 19, 2019 · 1 comment · Fixed by #30849
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone
8.0.0

Comments

@smitpatel
Copy link
Contributor

Cosmos does not have concept of subquery. (i.e. From ). Hence certain basic operations cannot be translated to server. Like Skip().Distinct() or Skip().Skip(). Since before applying Distinct we need to do a pushdown so that we skip elements before applying distinct.

For such operations, we need to throw exception message with useful information.
@smitpatel smitpatel mentioned this issue Jun 19, 2019
Merged
@divega divega changed the title Cosmos: Exception message when subquery pushdown is needed Cosmos: Improve exception message when subquery pushdown is needed Jun 20, 2019
@divega divega added this to the Backlog milestone Jun 20, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, MQ Sep 2, 2020
@smitpatel smitpatel removed their assignment Feb 12, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Apr 2, 2021
Closed
@smitpatel smitpatel mentioned this issue May 28, 2021
Closed
@smitpatel smitpatel modified the milestones: MQ, 7.0.0 Nov 19, 2021
@smitpatel
Copy link
Contributor Author

Moving to 7.0 to do it after cosmos refactor

@ajcvickers ajcvickers added punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Jul 7, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Jul 7, 2022
@smitpatel smitpatel removed their assignment Sep 14, 2022
@ajcvickers ajcvickers removed this from the Backlog milestone Mar 27, 2023
@ajcvickers ajcvickers self-assigned this May 8, 2023
@ajcvickers ajcvickers added this to the 8.0.0 milestone May 8, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 8, 2023
ajcvickers added a commit that referenced this issue May 8, 2023
@ajcvickers
Update exception message for Cosmos subquery pushdown
b267c49 
Fixes #16156
@ajcvickers ajcvickers mentioned this issue May 8, 2023
Merged
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview6 Jun 1, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview6, 8.0.0 Nov 14, 2023
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Update exception message for Cosmos subquery pushdown dotnet/efcore
4 participants
@divega @ajcvickers @smitpatel @AndriySvyryd