Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set operations over inheritance hierarchy project the same column twice #18832

Open
roji opened this issue Nov 10, 2019 · 2 comments
Open

Set operations over inheritance hierarchy project the same column twice #18832

roji opened this issue Nov 10, 2019 · 2 comments
Assignees
@roji
Labels
area-perf area-query punted-for-5.0 type-enhancement
Milestone
Backlog

Comments

@roji
Copy link
Member

roji commented Nov 10, 2019

In inheritance hierarchies, two properties from different entity types may be mapped to the same database column. When performing a set operation over a parent, the database column in question gets fetched twice.
@roji roji self-assigned this Nov 10, 2019
roji added a commit that referenced this issue Nov 10, 2019
@roji
Work on set operations and inheritance
28812bb 
Added support for set operations over different entity types.

When performing a set operation, if two properties in the entity
inheritance hierarchy were mapped to the same database column, that
column was projected twice.

Closes #16298
Fixes #18832
@roji roji mentioned this issue Nov 10, 2019
Closed
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 10, 2019
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 11, 2019
roji added a commit to roji/efcore that referenced this issue Nov 26, 2019
@roji
Work on set operations and inheritance
54620ca 
Added support for set operations over different entity types.

When performing a set operation, if two properties in the entity
inheritance hierarchy were mapped to the same database column, that
column was projected twice.

Closes dotnet#16298
Fixes dotnet#18832
roji added a commit to roji/efcore that referenced this issue Dec 10, 2019
@roji
Work on set operations and inheritance
25db93b 
Added support for set operations over different entity types.

When performing a set operation, if two properties in the entity
inheritance hierarchy were mapped to the same database column, that
column was projected twice.

Closes dotnet#16298
Fixes dotnet#18832
roji added a commit to roji/efcore that referenced this issue Dec 19, 2019
@roji
Work on set operations and inheritance
274a19e 
Added support for set operations over different entity types.

When performing a set operation, if two properties in the entity
inheritance hierarchy were mapped to the same database column, that
column was projected twice.

Closes dotnet#16298
Fixes dotnet#18832
@ajcvickers
Copy link
Member

@roji Likewise here.

@smitpatel
Copy link
Member

PR never got merged or updated.

@smitpatel smitpatel reopened this Mar 13, 2020
@smitpatel smitpatel removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 16, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-perf area-query punted-for-5.0 type-enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Work on set operations and inheritance dotnet/efcore
3 participants
@ajcvickers @smitpatel @roji