Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On*Removed conventions should run even if the declaring type was removed previously #19311

Closed
AndriySvyryd opened this issue Dec 13, 2019 · 0 comments · Fixed by #29042
Closed

On*Removed conventions should run even if the declaring type was removed previously #19311

AndriySvyryd opened this issue Dec 13, 2019 · 0 comments · Fixed by #29042
Labels
area-conventions area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported priority-bug Issues which requires API breaks and have bigger impact hence should be fixed earlier in the release punted-for-5.0 punted-for-6.0 type-bug
Milestone
7.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Dec 13, 2019 •
edited
Loading

This is especially important for foreign keys as the principal entity type might still be in the model.

Also add debug checks between execution to ensure previous convention didn't change any required state without terminating.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Dec 16, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Mar 14, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Jun 10, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 2, 2020
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, Backlog Sep 15, 2021
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Nov 10, 2021
@AndriySvyryd AndriySvyryd added the priority-bug Issues which requires API breaks and have bigger impact hence should be fixed earlier in the release label Sep 1, 2022
AndriySvyryd added a commit that referenced this issue Sep 10, 2022
@AndriySvyryd
Make On*Removed conventions run even if the declaring type was remove…
34d9f79 
…d previously

Fixes #19311
Fixes #20220
@AndriySvyryd AndriySvyryd removed their assignment Sep 10, 2022
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 10, 2022
@AndriySvyryd AndriySvyryd mentioned this issue Sep 10, 2022
Merged
@ajcvickers ajcvickers removed this from the 7.0.0 milestone Sep 12, 2022
@ajcvickers ajcvickers added this to the 7.0.0-rc2 milestone Sep 12, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-conventions area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported priority-bug Issues which requires API breaks and have bigger impact hence should be fixed earlier in the release punted-for-5.0 punted-for-6.0 type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Make On*Removed conventions run even if the declaring type was removed previously dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd