Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a warning for multiple collection Includes #19933

Closed
ajcvickers opened this issue Feb 14, 2020 · 3 comments · Fixed by #21419
Closed

Generate a warning for multiple collection Includes #19933

ajcvickers opened this issue Feb 14, 2020 · 3 comments · Fixed by #21419
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member

See this discussion for details: #18022
@ajcvickers ajcvickers self-assigned this Feb 14, 2020
@ajcvickers ajcvickers added this to the 3.1.x milestone Feb 14, 2020
@ajcvickers ajcvickers mentioned this issue Feb 14, 2020
Closed
ajcvickers added a commit that referenced this issue Mar 3, 2020
@ajcvickers
Add infrastructure for too many Includes warning.
83704d1 
Part of #19933
@ajcvickers ajcvickers mentioned this issue Mar 3, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 3.1.x, 5.0.0 Jun 15, 2020
@smitpatel smitpatel mentioned this issue Jun 16, 2020
Closed
@smitpatel smitpatel self-assigned this Jun 16, 2020
@smitpatel smitpatel removed this from the 5.0.0 milestone Jun 16, 2020
@ajcvickers
Copy link
Member Author

Should we also issue a warning when using split Include to warn of the potential consistency issues? Or is it assumed that you understand this when you opt-in?

@AndriySvyryd
Copy link
Member

@ajcvickers We should add that to the XML docs on AsSplitQuery

@ajcvickers ajcvickers added this to the 5.0.0 milestone Jun 22, 2020
@ajcvickers ajcvickers removed their assignment Jun 22, 2020
@smitpatel
Copy link
Contributor

Design meeting decisions:
Correlated with #21355
In the presence of 2 or more collection joins, we will log a warning guiding users to landing page of dotnet/EntityFramework.Docs#2479 which will explains pros/cons of both.
If user configures either scenario on context level using #21355 then we won't log a warning since user has explicitly decided to choose one behavior.

@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 26, 2020
smitpatel added a commit that referenced this issue Jun 26, 2020
@smitpatel
Query: Generate a warning for multiple collection Includes
7e92408 
Resolves #19933
@smitpatel smitpatel mentioned this issue Jun 26, 2020
Merged
smitpatel added a commit that referenced this issue Jun 26, 2020
@smitpatel
Query: Generate a warning for multiple collection Includes
b0db86c 
Resolves #19933
smitpatel added a commit that referenced this issue Jun 26, 2020
@smitpatel
Query: Generate a warning for multiple collection Includes (#21419)
3e5ee6c 
Resolves #19933
@ajcvickers ajcvickers removed this from the 5.0.0 milestone Jul 14, 2020
@ajcvickers ajcvickers added this to the 5.0.0-preview8 milestone Jul 14, 2020
@ajcvickers ajcvickers mentioned this issue Aug 27, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Generate a warning for multiple collection Includes dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd