Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: add translation for string.IndexOf(string, int) #25396

Closed
Tracked by #3868
maumar opened this issue Aug 3, 2021 · 1 comment · Fixed by #26623
Closed
Tracked by #3868

Query: add translation for string.IndexOf(string, int) #25396

maumar opened this issue Aug 3, 2021 · 1 comment · Fixed by #26623
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone
7.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Aug 3, 2021

we only translate overload that starts from the beginning. We could also translate the one that takes starting position, TSQL method has that overload also.
@ajcvickers ajcvickers added this to the Backlog milestone Aug 3, 2021
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Aug 3, 2021
yosoyhabacuc added a commit to yosoyhabacuc/efcore that referenced this issue Aug 23, 2021
@yosoyhabacuc
Query: add translation for string.IndexOf(string, int) dotnet#25396
0ae7b96
@yosoyhabacuc yosoyhabacuc mentioned this issue Aug 23, 2021
Closed
@yosoyhabacuc
Copy link
Contributor

I've added a PR with a proposal to implement the enhancement, It's basically taking the already existing logic for IndefOx and adding the start index at the end. The PR includes moving the logic to a method to be used by both versions (with or without the start index). I hope the proposal makes sense.

yosoyhabacuc added a commit to yosoyhabacuc/efcore that referenced this issue Sep 6, 2021
@yosoyhabacuc
Query: add translation for string.IndexOf(string, int) dotnet#25396
268bd95
smitpatel pushed a commit that referenced this issue Nov 11, 2021
@yosoyhabacuc @smitpatel
Query: SqlServer: Add translation for string.IndexOf(string, int)
813dafd 
Resolves #25396
@smitpatel smitpatel mentioned this issue Nov 11, 2021
Merged
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Nov 11, 2021
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 11, 2021
@ghost ghost closed this as completed in #26623 Nov 11, 2021
ghost pushed a commit that referenced this issue Nov 11, 2021
@smitpatel @yosoyhabacuc
Query: SqlServer: Add translation for string.IndexOf(string, int) (#2…
1ded243 
…6623)

* Query: SqlServer: Add translation for string.IndexOf(string, int)
Resolves #25396

* Update SqlServerStringMethodTranslator.cs

Co-authored-by: hfpt <[email protected]>
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers mentioned this issue Mar 1, 2022
Closed
This was referenced May 16, 2022
Merged
Closed
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Query: SqlServer: Add translation for string.IndexOf(string, int) dotnet/efcore
3 participants
@ajcvickers @maumar @yosoyhabacuc