Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: wrap more exceptions with DbUpdateException #25631

Closed
roji opened this issue Aug 20, 2021 · 0 comments · Fixed by #25651
Closed

Cosmos: wrap more exceptions with DbUpdateException #25631

roji opened this issue Aug 20, 2021 · 0 comments · Fixed by #25651
Assignees
@roji
Labels
area-cosmos area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@roji
Copy link
Member

roji commented Aug 20, 2021

Relational providers wrap all update exceptions in a DbUpdateException (except DbUpdateException and OperationCanceledException), but Cosmos only wraps CosmosException. Consider implementing the Relational behavior for Cosmos too.

Originally flagged in #15074 (comment)
@roji roji mentioned this issue Aug 20, 2021
Closed
roji added a commit that referenced this issue Aug 22, 2021
@roji
Fix Cosmos update exception wrapping
c24e868 
Fixes #25631
@roji roji mentioned this issue Aug 22, 2021
Merged
roji added a commit that referenced this issue Aug 24, 2021
@roji
Fix Cosmos update exception wrapping (#25651)
ca80da7 
Fixes #25631
@roji roji added this to the 6.0.0 milestone Aug 24, 2021
@roji roji self-assigned this Aug 24, 2021
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 26, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Aug 26, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-cosmos area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix Cosmos update exception wrapping dotnet/efcore
2 participants
@ajcvickers @roji