-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReaderModificationCommandBatch #27583
Labels
area-save-changes
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Milestone
Comments
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 7, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 14, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 14, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 17, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 17, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 17, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 18, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
roji
added a commit
to roji/efcore
that referenced
this issue
Mar 18, 2022
* Allow flexible/alternative parameter strategies * Insert commands and update SQL immediately Closes dotnet#27583
ajcvickers
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Mar 31, 2022
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-save-changes
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
As discussed offline with @AndriySvyryd, ReaderModificationCommandBatch currently adds a parameter for each IColumnModification, for each modification command - in order. This makes it difficult to implement patterns which do fancy things with parameters. For example, on PostgreSQL insertion of multiple rows can be optimized as follows:
Where @i and @n are array for the column values of the different rows.
In addition, I think we can simplify the current design and apply commands to the batch directly as they're added, as opposed to the current CachedCommandText mechanism.
The text was updated successfully, but these errors were encountered: