ExecuteUpdate fails when target entity has an owned entity

[smitpatel]

No description provided.

[keatkeat87]

I got this error when calling ExecuteDeleteAsync on a model having Owned Entity.
https://github.com/keatkeat87/EFCore7_ExecuteDeleteAsync

[ajcvickers]

@keatkeat87 Please try with the daily build.

[Sebazzz]

I also got an issue with an entity that has owned entities, but I'm setting the property on the entity itself:

            await this._applicationDbContext.Sources
                      .Where(s => s.CopiedFromId == source.Id)
                      .ExecuteUpdateAsync(action => action.SetProperty(s => s.CopiedFrom, (Source) null), cancellationToken);

It goes wrong here because expression.Expression is an IncludeExpression instead of EntityShaperExpression:

This translation happens here, in the ReplacingExpressionVisitor:

[roji]

This happens because the property selector lambda has an IncludeExpression wrapping the RelationalEntityShaperExpression.

To unblock use of ExecuteUpdate on non-owned properties, we can just unwrap the IncludeExpressions (there may be more than one); as long as after unwrapping, we get a PropertyExpression directly over RelationalEntityShaperExpression, things should work fine. I will do this in #29672, which is very similar, allowing interface up-casts in update property selectors.

However, allowing ExecuteUpdate to reference owned properties is another matter (i.e. with table sharing, or possibly JSON - see #28766), and more complex. We should split that out to another issue.

[roji]

Allowing referencing owned properties in the property selector is covered by #28627.

[roji]

Clearing milestone to discuss patching