Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in aka.ms link #28771

Closed
rygargamel opened this issue Aug 18, 2022 · 2 comments · Fixed by #28770 or dotnet/EntityFramework.ApiDocs#118
Closed

Typo in aka.ms link #28771

rygargamel opened this issue Aug 18, 2022 · 2 comments · Fixed by #28770 or dotnet/EntityFramework.ApiDocs#118
Assignees
@smitpatel @roji
Labels
area-api-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
7.0.0

Comments

@rygargamel
Copy link

The Remarks section has a type in an aka link.

As written:

Remarks

See Modeling entity types and relationships and EF Core model-building conventions for more information.

https://aka.ms/efcore-docs-coventions should be https://aka.ms/efcore-docs-conventions

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@roji roji transferred this issue from dotnet/EntityFramework.Docs Aug 18, 2022
@roji roji mentioned this issue Aug 18, 2022
Merged
@roji roji self-assigned this Aug 18, 2022
@roji roji added this to the 7.0.0 milestone Aug 18, 2022
@roji
Copy link
Member

roji commented Aug 18, 2022

Thanks, submitted #28770 to fix this.

@smitpatel smitpatel self-assigned this Aug 18, 2022
@smitpatel smitpatel reopened this Aug 18, 2022
@smitpatel
Copy link
Contributor

I will update the live docs.

smitpatel added a commit to dotnet/EntityFramework.ApiDocs that referenced this issue Aug 22, 2022
@smitpatel
Fix typo in doc links
0461860 
Resolves dotnet/efcore#28771
@smitpatel smitpatel mentioned this issue Aug 22, 2022
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 22, 2022
smitpatel added a commit to dotnet/EntityFramework.ApiDocs that referenced this issue Aug 22, 2022
@smitpatel
Fix typo in doc links
ecd8033 
Resolves dotnet/efcore#28771
@smitpatel smitpatel modified the milestones: 7.0.0, 7.0.0-rc2 Aug 29, 2022
TianqiZhang added a commit to dotnet/EntityFramework.ApiDocs that referenced this issue Sep 9, 2022
@TianqiZhang @smitpatel @shawnwang-ms
Merge accumulated changes from main to live (#120)
0e6cb5a 
* Fix typo in doc links

Resolves dotnet/efcore#28771

* [SEO][Rollout Monikered Canonical]Add URL moniker (#119)

Co-authored-by: Smit Patel <[email protected]>
Co-authored-by: Shawn Wang <[email protected]>
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

@roji roji

Labels
area-api-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix typo in aka.ms links roji/efcore
Fix typo in doc links dotnet/EntityFramework.ApiDocs
4 participants
@ajcvickers @smitpatel @roji @rygargamel