Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw for sync APIs when using Cosmos since they do sync over async #32563

Closed
ajcvickers opened this issue Dec 8, 2023 · 1 comment · Fixed by #33386
Closed

Throw for sync APIs when using Cosmos since they do sync over async #32563

ajcvickers opened this issue Dec 8, 2023 · 1 comment · Fixed by #33386
Labels
area-cosmos breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Member

No description provided.

@ajcvickers
Copy link
Member Author

Note from triage: consider deprecating with a switch to opt-in.

@ajcvickers ajcvickers self-assigned this Jan 4, 2024
@ajcvickers ajcvickers added this to the Backlog milestone Jan 4, 2024
@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
ajcvickers added a commit that referenced this issue Mar 24, 2024
@ajcvickers
Make Cosmos provider throw for sync I/O
189b185 
Fixes #32563

This change adds an error via logging which is thrown on any use of sync I/O with Cosmos. This can currently be disabled to allow sync again, but ultimately this will be removed--probably in 11.

Also, makes all test infrastructure async-only. This means an EF provider only needs to support async APIs to use our test infra.
@ajcvickers ajcvickers mentioned this issue Mar 24, 2024
Merged
@roji roji modified the milestones: Backlog, 9.0.0 Mar 25, 2024
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 25, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview4 Apr 2, 2024
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
@roji roji modified the milestones: 9.0.0-preview4, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Make Cosmos provider throw for sync I/O dotnet/efcore
2 participants
@ajcvickers @roji