Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Cosmos query pipeline code with latest relational code #33032

Closed
ajcvickers opened this issue Feb 8, 2024 · 2 comments · Fixed by #33998
Closed

Align Cosmos query pipeline code with latest relational code #33032

ajcvickers opened this issue Feb 8, 2024 · 2 comments · Fixed by #33998
Assignees
@roji
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
@ajcvickers ajcvickers added this to the 9.0.0 milestone Feb 14, 2024
@roji
Copy link
Member

roji commented May 18, 2024 •
edited
Loading

After some examination, most of the Cosmos query pipeline is in relatively decent shape - aligned more or less to the relational query pipeline; I did NRT annotating (#33584) and some cleanup/styling (#33637), but beyond that I think we should be good to go.

The part that likely requires attention and a possible rewrite/alignment is the shaper generation; assigning to @ajcvickers and @maumar. Note that there will likely be some shaper work as well for new features, e.g. complex type mapping.

@roji roji assigned ajcvickers and maumar and unassigned roji May 18, 2024
@roji roji assigned roji and unassigned ajcvickers and maumar Jun 15, 2024
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 15, 2024
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
@roji
Cosmos querying over arrays of structural type
7a85df8 
Closes dotnet#16926
Closes dotnet#20441
Closes dotnet#25700
Closes dotnet#25701
Closes dotnet#33032
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
@roji
Cosmos querying over arrays of structural type
39f890e 
Closes dotnet#16926
Closes dotnet#20441
Closes dotnet#25700
Closes dotnet#25701
Closes dotnet#33032
@roji roji mentioned this issue Jun 15, 2024
Merged
@roji
Copy link
Member

roji commented Jun 15, 2024

Significant additional work has been done in #33998 - at this point we should probably track specific issues/problems as they come up.

Work on shaper generation definitely remains (e.g. NRT annotation), but we can track that via specific issues as well.

roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
@roji
Cosmos querying over arrays of structural type
92f348b 
Closes dotnet#16926
Closes dotnet#20441
Closes dotnet#29497
Closes dotnet#25700
Closes dotnet#25701
Closes dotnet#33032
roji added a commit to roji/efcore that referenced this issue Jun 15, 2024
@roji
Cosmos querying over arrays of structural type
f4c0b07 
Closes dotnet#16926
Closes dotnet#20441
Closes dotnet#29497
Closes dotnet#25700
Closes dotnet#25701
Closes dotnet#33032
@roji roji closed this as completed in 531c238 Jun 20, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview6 Jun 21, 2024
@roji roji modified the milestones: 9.0.0-preview6, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Cosmos querying over arrays of structural type roji/efcore
3 participants
@ajcvickers @maumar @roji