-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos: Switch the default discriminator property to $type #34269
Labels
area-cosmos
area-model-building
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Milestone
Comments
ajcvickers
added a commit
that referenced
this issue
Aug 2, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added a commit
that referenced
this issue
Aug 2, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added a commit
that referenced
this issue
Aug 2, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Aug 2, 2024
ajcvickers
added a commit
that referenced
this issue
Aug 2, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added a commit
that referenced
this issue
Aug 2, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added a commit
that referenced
this issue
Aug 5, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
ajcvickers
added a commit
that referenced
this issue
Aug 6, 2024
…o "$type" Fixes #34269 Use the following to revert back to the old behavior: ```C# modelBuilder.HasEmbeddedDiscriminatorName("Discriminator"); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-cosmos
area-model-building
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Our current discriminator property in JSON is called
Discriminator
; but an emerging semi-standard is for$type
to be used as the discriminator property (e.g. S.T.Json's polymorphism support); aligning with that would increase the interoperability of documents produced by default by EF with other JSON tools. Given that we're already introducing lots of breaking changes in the Cosmos provider in 9.0, we should do this one as well.Notes:
$type
discriminator property discussed in this issue should most likely always contain the regular, concrete discriminator value only.The text was updated successfully, but these errors were encountered: