Design: Refine code generation APIs #10481
Conversation
| /// A service typically implemented by database providers to generate code fragments | ||
| /// for reverse engineering. | ||
| /// </summary> | ||
| public interface IScaffoldingProviderCodeGenerator2 |
|
|
||
| foreach (var argument in arguments) | ||
| { | ||
| Arguments.Add(argument); |
There was a problem hiding this comment.
AddRange or ctor args to create the list.
There was a problem hiding this comment.
IList doesn't have AddRange, and I couldn't see an already existing extension method.
|
Looks like I need to update Oracle more too... |
Yeah, I debated whether to use MethodCallCodeFragment here too... |
|
I was thinking more like, for SqlServer provider, provider can use connection string to find out server version and call those additional things like |
|
We'll YAGNI it for now. Now we can actually evolve this service without breaking providers. 😉 |
|
Filed #10487 |
This removes the concept of the programming language from the provider APIs.
| @@ -26,6 +26,7 @@ public static class ScaffoldingServiceCollectionExtensions | |||
| public static IServiceCollection AddScaffolding([NotNull] this IServiceCollection serviceCollection, [NotNull] IOperationReporter reporter) | |||
| => serviceCollection | |||
| .AddSingleton<AnnotationCodeGeneratorDependencies>() | |||
| .AddSingleton<CoreTypeMapperDependencies>() | |||
There was a problem hiding this comment.
We really need to add more RevEng tests. (#9111) I'll try to get to it soon.
cc @ajcvickers
This removes the concept of the programming language from the provider APIs.