Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using response files from EF commands #10552

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Add support for using response files from EF commands #10552

merged 1 commit into from
Dec 19, 2017

Conversation

jsacapdev
Copy link
Contributor

Summary of the changes

  • Enable response files at command line

Manual tests include:

dotnet ./dotnet-ef.dll migrations add initial @BloggingContext.ef.config

(BloggingContext.ef.config contents)

-p
C:\playground\AppToBuilder\AppToBuilder.csproj
-s
C:\playground\AppToBuilder\AppToBuilder.csproj

dotnet ./dotnet-ef.dll @BloggingContext.ef.config

(BloggingContext.ef.config contents)

migrations
add
initial
-p
C:\playground\AppToBuilder\AppToBuilder.csproj
-s
C:\playground\AppToBuilder\AppToBuilder.csproj

Relative path:
dotnet ./dotnet-ef.dll migrations add initial @D:/BloggingContext.ef.config

Error condition (no migration name):
dotnet ./dotnet-ef.dll migrations add @D:/BloggingContext.ef.config

Fixes #10409

- Enable response files at command line

Manual tests include:

1. dotnet ./dotnet-ef.dll migrations add initial @BloggingContext.ef.config

(BloggingContext.ef.config contents)
-p
C:\playground\AppToBuilder\AppToBuilder.csproj
-s
C:\playground\AppToBuilder\AppToBuilder.csproj

2. dotnet ./dotnet-ef.dll @BloggingContext.ef.config

(BloggingContext.ef.config contents)
migrations
add
initial
-p
C:\playground\AppToBuilder\AppToBuilder.csproj
-s
C:\playground\AppToBuilder\AppToBuilder.csproj

3. dotnet ./dotnet-ef.dll migrations add initial @d:/BloggingContext.ef.config (relative path)

4. dotnet ./dotnet-ef.dll migrations add @d:/BloggingContext.ef.config (error condition, results in Missing required argument '<NAME>'.)

Fixes #10409
@jsacapdev jsacapdev changed the title Summary of the changes Add support for using response files from EF commands Dec 14, 2017
@bricelam bricelam self-assigned this Dec 14, 2017
@bricelam
Copy link
Contributor

Very cool. I verified this lights up in dotnet ef too.

@bricelam bricelam merged commit 6e260b4 into dotnet:dev Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants