Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support replacement of services that allow multiple registrations #19393

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Support replacement of services that allow multiple registrations #19393

merged 1 commit into from
Dec 26, 2019

Conversation

ajcvickers
Copy link
Member

Fixes #13479

AndriySvyryd
AndriySvyryd approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:, but opened #19394 to reduce impact on startup time

@ajcvickers ajcvickers merged commit 402938a into master Dec 26, 2019
@ajcvickers ajcvickers deleted the KnowingWhenToStop1223 branch December 26, 2019 17:48
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace service doesn't work correctly for IConventionSetBuilder
3 participants
@ajcvickers @smitpatel @AndriySvyryd