Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.1] Fix to #19825 - Query: incorrectly generating JOIN rather than APPLY for subqueries with outside references to a joined table #20064

Merged
merged 1 commit into from
Apr 4, 2020
Merged

[3.1] Fix to #19825 - Query: incorrectly generating JOIN rather than APPLY for subqueries with outside references to a joined table #20064

merged 1 commit into from
Apr 4, 2020

Commits on Feb 25, 2020

  1. Fix to #19825 - Query: incorrectly generating JOIN rather than APPLY … 

    …for subqueries with outside references to a joined table

During translation, when we decide whether we can apply JOIN or APPLY we visit inner SelectExpression looking for references to tables in the outer SelectExpression.
Problem was that we were using Contains method, which would not match cases where the outer table was in the form of JoinExpressionBase.
Fix is to use ContainsTableReference method which matches different types of tables.
    @maumar
    maumar committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    de34606 View commit details
    Browse the repository at this point in the history