Fix to #20003 - Convert multiple equality/in-equality on same column joined by Or/Else into SQL IN expression #21476

maumar · 2020-07-01T04:10:35Z

Various optimizations to queries with IN:

a == X || a == Y -> a IN (X, Y)
a != X && a != Y -> a NOT IN (X, Y)
a IN (X) -> a == X
a IN (X, Y) || a IN (Z, W) -> a IN (X, Y, Z, W)
a IN (X, Y, Z) && a IN (Y, Z, W) -> a IN (Y, Z)

Fixes #20003

create negation unit tests add parentheses to negated expression on translation expose unit test to sqlite test suite add unit tests for negating a column and LIKE expression use RequiresBrackets helper Fixes #13919

…joined by Or/Else into SQL IN expression Various optimizations to queries with IN: - a == X || a == Y -> a IN (X, Y) - a != X && a != Y -> a NOT IN (X, Y) - a IN (X) -> a == X - a IN (X, Y) || a IN (Z, W) -> a IN (X, Y, Z, W) - a IN (X, Y, Z) && a IN (Y, Z, W) -> a IN (Y, Z) Fixes #20003

maumar · 2020-07-01T04:13:05Z

src/EFCore.Relational/Query/Internal/SqlExpressionSimplifyingExpressionVisitor.cs

+                    caseComponent);
+            }
+
+            var left = (SqlExpression)Visit(sqlBinaryExpression.Left);


this is the part that was added

jonlouie and others added 3 commits June 30, 2020 02:43

Fix Issue #13919: Translation error using negative

1b7822f

create negation unit tests add parentheses to negated expression on translation expose unit test to sqlite test suite add unit tests for negating a column and LIKE expression use RequiresBrackets helper Fixes #13919

Merge branch 'master' of https://github.com/dotnet/efcore

d43a411

maumar requested review from smitpatel and roji July 1, 2020 04:10

maumar commented Jul 1, 2020

View reviewed changes

maumar closed this Jul 1, 2020

maumar deleted the fix20003 branch July 1, 2020 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix to #20003 - Convert multiple equality/in-equality on same column joined by Or/Else into SQL IN expression #21476

Fix to #20003 - Convert multiple equality/in-equality on same column joined by Or/Else into SQL IN expression #21476

maumar commented Jul 1, 2020

maumar Jul 1, 2020

Fix to #20003 - Convert multiple equality/in-equality on same column joined by Or/Else into SQL IN expression #21476

Fix to #20003 - Convert multiple equality/in-equality on same column joined by Or/Else into SQL IN expression #21476

Conversation

maumar commented Jul 1, 2020

maumar Jul 1, 2020

Choose a reason for hiding this comment