-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to daily build guidance after feedback #22481
Conversation
@bricelam Updated based on your feedback. |
@Pilchie FYI |
## Using daily builds | ||
|
||
The daily builds are not published to NuGet.org because there are way too many of them! Instead they can be pulled from a custom NuGet feed. To access this feed, create a `NuGet.config` file in the same directory as your .NET solution or projects. The file should contain the following content: | ||
The daily builds are not published to NuGet.org because the .NET build infrastructure is not set up for this. Instead they can be pulled from a custom NuGet feed. To access this feed, create a `NuGet.config` file in the same directory as your .NET solution or projects. The file should contain the following content: | ||
|
||
```xml | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<packageSources> | ||
<clear /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've often wondered if we should also do this:
<disabledPackageSources>
<clear />
</disabledPackageSources>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That way, if they've unchecked a source in Visual Studio, it would still work on this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. It would have helped people who have got stuck in the past. Is there a chance it will break people?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably makes more sense for our repo. I can't see it breaking anyone. (when paired with the clear
here.)
Maybe we shouldn't reccomend adding <clear />
under packageSources
since they may be using other github/myget/azdo feeds defined in their global/user config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at one point we wanted to make sure that NuGet.org was the last feed. I suspect that this shouldn't matter for us either, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, there was some weird behavior around it in earlier versions of NuGet. I think it was while they were transitioning to the v3 protocol, but I can't remember the details. Probably not an issue anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and it probably was slowing down our builds a bit hitting nuget.org for the hundreds of packages in 1.x
No description provided.