Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to daily build guidance for EF Core 5.0/EF Core 6.0 #22535

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

ajcvickers
Copy link
Member

Also changed the guidance around clearing package sources.

Also changed the guidance around clearing package sources.
docs/DailyBuilds.md Outdated Show resolved Hide resolved

### Using wildcards

The easiest way to use daily builds is with wildcards in project references. For example:
The easiest way to use daily builds is with wildcards in project references. For example, for EF Core 6.0 daily builds:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure floating versions are a good guidance to give, because stuff breaks as new packages are released - that can give a pretty negative experience to daily builds and may make people avoid them (because they don't know they can do differently). I'd recommend doing things as usual without floating.

But that definitely seems out of scope for this PR, plus the 5.0 daily builds are now as stable as anything else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe for our daily builds this is probably the best guidance we can give. If we lose confidence in the quality of the dailys, then maybe we should consider not recommending this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was less about quality, and more about APIs/behavior intentionally changing and breaking people.

@ajcvickers
Copy link
Member Author

@bricelam Hoping to get your review on this before merging.

Co-authored-by: Shay Rojansky <[email protected]>
@ajcvickers ajcvickers merged commit 3922e18 into main Sep 18, 2020
@ajcvickers ajcvickers deleted the ParallelUniverses0914 branch September 18, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants