Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for previously fixed issues #22648

Merged
1 commit merged into from
Sep 22, 2020
Merged

Adding tests for previously fixed issues #22648

1 commit merged into from
Sep 22, 2020

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Sep 21, 2020

Resolves #12274
Resolves #11835
Resolves #12597
Resolves #12379
Resolves #12717
Resolves #17775
Resolves #18962

@smitpatel
Copy link
Contributor

#17775 was flaky and underlying issue may not be gone. Make sure to run all the tests in SqlServer functional tests multiple times to verify that it is not flaky.

@maumar maumar force-pushed the verify_fixed branch 5 times, most recently from d2273fd to bbcc127 Compare September 22, 2020 04:57
Resolves #12274
Resolves #11835
Resolves #12597
Resolves #12379
Resolves #12717
Resolves #17775
Resolves #18962
@ghost
Copy link

ghost commented Sep 22, 2020

Hello @maumar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@maumar
Copy link
Contributor Author

maumar commented Sep 22, 2020

@msftbot require 1 approval

@ghost
Copy link

ghost commented Sep 22, 2020

Hello @maumar!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit c13f8b4 into main Sep 22, 2020
@ghost ghost deleted the verify_fixed branch September 22, 2020 22:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment