Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable xUnit analyzers #23194

Merged
1 commit merged into from
Nov 5, 2020
Merged

Re-enable xUnit analyzers #23194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions test/Directory.Build.targets
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions test/EFCore.Proxies.Tests/ChangeDetectionProxyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public void Does_not_throw_when_non_virtual_indexer_not_mapped()
{
using var context = new ChangeContext<ChangeNonVirtualIndexerNotUsed>();

Assert.False(
context.Model.FindEntityType(typeof(ChangeNonVirtualIndexerNotUsed)).GetProperties().Any(e => e.IsIndexerProperty()));
Assert.DoesNotContain(
context.Model.FindEntityType(typeof(ChangeNonVirtualIndexerNotUsed)).GetProperties(), e => e.IsIndexerProperty());
}

[ConditionalFact]
Expand Down Expand Up @@ -318,7 +318,7 @@ public void Raises_changing_event_when_equal_and_check_equality_false(bool useLa
private class ChangeContext<TEntity> : TestContext<TEntity>
where TEntity : class
{
private Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
private readonly Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;

public ChangeContext(
bool useLazyLoading = false,
Expand All @@ -343,7 +343,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
private class SharedChangeContext<TEntity> : DbContext
where TEntity : class
{
private Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;
private readonly Action<EntityTypeBuilder<TEntity>> _entityBuilderAction;

public SharedChangeContext(Action<EntityTypeBuilder<TEntity>> entityBuilderAction = null)
{
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Relational.Tests/Migrations/Internal/MigrationsModelDifferTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ public void Model_differ_breaks_double_foreign_key_cycles_in_create_table_operat

var createBankTableOperation = Assert.IsType<CreateTableOperation>(result[0]);
Assert.Equal("Banks", createBankTableOperation.Name);
Assert.Equal(0, createBankTableOperation.ForeignKeys.Count);
Assert.Empty(createBankTableOperation.ForeignKeys);

Assert.Equal(4, result.OfType<AddForeignKeyOperation>().Count());
});
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.SqlServer.FunctionalTests/Query/QueryBugsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9310,7 +9310,7 @@ public virtual void Query_filter_with_contains_evaluates_correctly()
{
using var context = new MyContext10295(_options);
var result = context.Entities.ToList();
Assert.Equal(1, result.Count);
Assert.Single(result);

AssertSql(
@"SELECT [e].[Id], [e].[Name]
Expand Down