[5.0.2] Stop marking the inverse navigation as loaded when loading a many-to-many navigation #23589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
changed the title
smitpatel
reviewed
Dec 4, 2020
smitpatel
reviewed
Dec 4, 2020
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.Expressions.cs
Outdated
Show resolved
Hide resolved
|
Add some additional tests around using |
|
@smitpatel Updated and added new tests. |
smitpatel
reviewed
Dec 6, 2020
src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.Expressions.cs
Show resolved
Hide resolved
smitpatel
approved these changes
Dec 7, 2020
|
@dotnet/efteam Given the risk, I would appreciate some additional reviews on this. In particular, from @maumar, but also from anyone else. Look for cases where this change may impact other queries, such as the cases that Smit has previously called out. |
|
Approved by Tactics for 5.0.2. Please wait for the branch to open before merging. |
|
@ajcvickers you could also add test that uses query with Include/FilteredInclude directly and make sure that the other side is not being loaded. |
maumar
approved these changes
Dec 9, 2020
…many navigation Fixes #23475 This is a targeted patch fix which special cases many-to-many loading. I will file an issue for a more general solution using an appropriate general update to query.
…irst time with setLoaded = false.
ajcvickers
force-pushed
the
LoadedBakedPotatoSkips1130
branch
from
e623114
to
45d27f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23475
This is a targeted patch fix which special cases many-to-many loading. I will file an issue for a more general solution using an appropriate general update to query. See #22022.
Description
This is a bug in many-to-many relationships, a major new feature in EF Core 5.0. When loading a collection navigation property, the inverse navigation property is marked as loaded. This is not correct, since only entities related to the source entity are loaded. This means that attempting to load the inverse is a no-op because it is already marked as loaded, and hence data is missing in the context.
Customer Impact
Related entities are not loaded from the database when they should be, leading to possible data corruption in an application that assumes this is working correctly. This will kind of problem is often hard to find since there is no error, just incorrect data.
How found
Customer reported on 5.0.0.
Test coverage
We did not have test coverage for this case. However, this isn't why we didn't catch this, since I didn't think about the consequences for the IsLoaded flag here, and only investigation of this issue made me realize the mistake. We have added more test coverage in this PR.
Regression?
No; new feature in 5.0.
Risk
Medium. The underlying problem is that we ere using
Includein the generated query to do lazy loading. The behavior of Include is to set the collection as loaded, even if filtered, which means we can't change the default behavior of Include. Therefore, we have introduced a new internalNotQuiteIncludemethod that is processed the same asIncludein the query pipeline, but then changes the final materialization delegate to indicate that the collection should not be loaded. This is new code path has been done in a way that it is only used for this case, and can be disabled with a quirk switch. It has also been reviewed in detail by the team and we have added more testing.