Tools: Annotate NRTs #24226
Tools: Annotate NRTs #24226
Conversation
| @@ -28,11 +28,11 @@ internal static class Exe | |||
| startInfo.WorkingDirectory = workingDirectory; | |||
| } | |||
|
|
|||
| var process = Process.Start(startInfo); | |||
| var process = Process.Start(startInfo)!; | |||
There was a problem hiding this comment.
Just for kicks, Process.Start can indeed return null in some circumstances (process could not be started? Not sure when you get null and when an exception...)
There was a problem hiding this comment.
I noticed that, but decided that a null-ref was just as useful as any message we could throw: "Couldn't start a process. Try FORMAT C:\ then run dotnet-ef again."
| _suppressOnConfiguring.HasValue(), | ||
| _noPluralize.HasValue()); | ||
| if (_json.HasValue()) | ||
| _provider!.Value!, |
There was a problem hiding this comment.
Another strategy is to annotate these as non-nullable and force-initialize to null, encoding the assumption that they will only be accessed after Configure has completed. That restricts the ugliness to the initialization, rather than every time they're accessed. If all accesses to these are always gonna have a bang, might as well...
There was a problem hiding this comment.
I like it this way better. You could, although it's unlikely, add new code that tries to use them before Init (or in this case, Configure) is called.
All of the warnings reinforce how bad the Init pattern is, and will remind me to try even harder avoid it in the future. 😉
Part of dotnet#19007
|
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
Part of #19007