Create a read-optimized implementation of IModel #24364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Mar 11, 2021
smitpatel
reviewed
Mar 11, 2021
smitpatel
reviewed
Mar 11, 2021
roji
reviewed
Mar 11, 2021
| @@ -1411,6 +1412,9 @@ | |||
| <data name="SkipNavigationWrongType" xml:space="preserve"> | |||
| <value>The skip navigation '{navigation}' cannot be removed from the entity type '{entityType}' because it is defined on the entity type '{otherEntityType}'.</value> | |||
| </data> | |||
| <data name="SlimModelMissingData" xml:space="preserve"> | |||
| <value>The requested configuration is not stored in the read-optimized model, please use 'DbContext.DesignTimeModel'.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>The requested configuration is not stored in the read-optimized model, please use 'DbContext.DesignTimeModel'.</value> | |
| <value>The requested configuration is not stored in the slim model, please use 'DbContext.DesignTimeModel'.</value> |
There was a problem hiding this comment.
I think the original has more meaning
There was a problem hiding this comment.
OK, but shouldn't we be consistent between our messages and the actual type naming etc.?
There was a problem hiding this comment.
Sure, but I don't want to name the type ReadOptimizedModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8258