ComplexNavigations test refactoring #24709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maumar
commented
Apr 21, 2021
maumar
commented
- moving collection navigation related tests to separate test class
- adding split query tests for all these collection-related tests
- removing dedicated split query tests, which were just copies of some of the collection tests
- for now, split query tests are disabled
maumar
commented
Apr 21, 2021
| return base.Take_Select_collection_Take(async); | ||
| } | ||
|
|
||
| [ConditionalTheory(Skip = "Split query bug")] |
maumar
force-pushed
the
split_complex_navs_rebase
branch
from
2250084
to
e830e9c
Compare
smitpatel
approved these changes
Apr 21, 2021
- moving collection navigation related tests to separate test class - adding split query tests for all these collection-related tests - removing dedicated split query tests, which were just copies of some of the collection tests - for now, split query tests are disabled
maumar
force-pushed
the
split_complex_navs_rebase
branch
from
e830e9c
to
9fe0d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.