API review updates #25450
Merged
API review updates #25450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #24743 - Add params to ContextParameterBinding and related - Remove RelationalConnection.DbConnectionState - Move commandSource constructor parameters to the end in *EventData classes and IRelationalCommandDiagnosticsLogger
roji
approved these changes
Aug 8, 2021
| @@ -21,7 +21,7 @@ public class ContextParameterBinding : ServiceParameterBinding | |||
| /// <param name="serviceProperties"> The associated <see cref="IServiceProperty" /> objects, or <see langword="null" />. </param> | |||
| public ContextParameterBinding( | |||
| Type contextType, | |||
| IPropertyBase[]? serviceProperties = null) | |||
| params IPropertyBase[]? serviceProperties) | |||
There was a problem hiding this comment.
Should probably make the array non-nullable - with params we just get an empty one (here and below).
Suggested change
| params IPropertyBase[]? serviceProperties) | |
| params IPropertyBase[] serviceProperties) |
There was a problem hiding this comment.
It was previously possible to pass null directly, so we should not break that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24743