[6.0] Fix snapshot generation with HiLo #26136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Sep 22, 2021
ajcvickers
changed the title
ajcvickers
approved these changes
Sep 22, 2021
|
Approved for EFCore 6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26134
Description
Incorrect migration generated when the HiLo value generation strategy is configured.
Customer impact
Generating migrations with a model-wide HiLo value generation strategy creates an invalid migration.
How found
Customer
Regression
Yes
Testing
Test for this scenario added in the PR.
Risk
Low, the bug is trivial and the modified code only annotation generation for this particular scenario; coverage is good in this area.