Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No test left behind #26382

Merged
merged 1 commit into from
Oct 19, 2021
Merged

No test left behind #26382

merged 1 commit into from
Oct 19, 2021

Conversation

ajcvickers
Copy link
Member

@ajcvickers ajcvickers commented Oct 17, 2021

Part of #26088 and #17235

Ideas for better catching behavior changes in the product code. Specifically:

  • Detect when a negative case stops failing
  • Detect when a negative case starts failing in a different way

Fundamental approach: don't skip tests.

In NorthwindAggregateOperatorsQueryTests, we had:

  • Negative cases that were no longer failing
  • Negative cases that were skipped for all providers, but worked on some. For example:
    • Failed on relational, but passed on in-memory
    • Failed on relational, but passed on Cosmos
    • Failed on SQL Server, but passed on SQLite
  • Negative cases that failed in different ways on different providers

Specifics:

  • If a test throws, catch the exception
    • Where feasible, also validate the exception message or error number
  • Always call base where possible, rather than repeating the query in an overriden test
  • Add a standard comment where we have a bug or enhancement tracking the issue. For example:
    • // Contains over subquery. Issue #17246.
  • Always have an AssertSql call in Cosmos and SQL Server tests
    • Where we expect a provider-specific class to verify SQL, then add a test that checks all test methods are overriden.

Part of #26088 and #17235

Ideas for better catching behavior changes in the product code. Specifically:
- Detect when a negative case stops failing
- Detect when a negative case starts failing in a different way

Fundamental approach: don't skip tests.

In NorthwindAggregateOperatorsQueryTests, we had:
- Negative cases that were no longer failing
- Negative cases that were skipped for all providers, but worked on some. For example:
  - Failed on relational, but passed on in-memory
  - Failed on relational, but passed on Cosmos
  - Failed on SQL Server, but passed on SQLite
- Negative cases that failed in different ways on different providers

Specifics:
- If a test throws, catch the exception
  - Were feasible, also validate the exception message or error number
- Always call base where possible, rather than repeating the query in an overriden test
- Add a standard comment where we have a bug or enhancement tracking the issue. For example:
  - `// Contains over subquery. Issue #17246.`
- Always have an `AssertSql` call in Cosmos and SQL Server tests
  - Where we expect a provider-specific class to verify SQL, then add a test that checks all test methods are overriden.
@ajcvickers ajcvickers requested a review from a team October 17, 2021 10:55
@ajcvickers ajcvickers merged commit dbc4314 into main Oct 19, 2021
@ajcvickers ajcvickers deleted the NoTestLeftBehind1016 branch October 19, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants